QA: bump minimum supported PHP version to 7.3 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
froschdesign
commented
Jun 22, 2020
froschdesign
commented
| Q | A |
|---|---|
| Enhancement | yes |
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
There was a problem hiding this comment.
@froschdesign Subject of the PR is bump PHP version, but the most changes here is around tests and adding void RTH. This is redundant, not sure if we decided to do that as it has no any value (especially in tests).
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
froschdesign
force-pushed
the
feature/bump-php-version
branch
from
b27abe5
to
7ccc389
Compare
froschdesign
added this to In progress
in Bumping PHP version, updating coding standard and dependencies
via automation
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
froschdesign
force-pushed
the
feature/bump-php-version
branch
from
ea29fa6
to
2d20d65
Compare
weierophinney
added a commit
that referenced
this pull request
Sep 10, 2020
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Bumping PHP version, updating coding standard and dependencies
automation
moved this from In progress
to Done
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.