Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vimeo/psalm to CI setup #17

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Add vimeo/psalm to CI setup #17

merged 3 commits into from
Oct 29, 2021

Conversation

doganoo
Copy link

@doganoo doganoo commented Oct 28, 2021

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

This PR adds psalm support. I followed the instructions by @boesing as much as possible, but unfortunately, not everything was feasible:

  • there is no .travis.yml to adjust
  • there is no phpstan in the project and no phpstan.neon.dist

There is no master branch and therefore I am targeting 1.5.x. Please let me know if this is not right and I will adjust.

Fixes #7

@Ocramius
Copy link
Member

@doganoo all good - patch does indeed add vimeo/psalm to this repository's toolchain, which is more than enough as a start :)

As for the default branch: that is intentional. laminas/ repositories no longer use the master branch, and instead, we name the default branch based on the version it will be tagged with next.

@Ocramius Ocramius self-assigned this Oct 29, 2021
@Ocramius Ocramius added this to the 1.5.0 milestone Oct 29, 2021
@Ocramius
Copy link
Member

Thanks @doganoo!

@Ocramius Ocramius merged commit a560f42 into laminas:1.5.x Oct 29, 2021
@Ocramius Ocramius changed the title adds psalm support Add vimeo/psalm to CI setup Oct 29, 2021
@doganoo
Copy link
Author

doganoo commented Oct 29, 2021

cool that this worked so quickly and easily ☺️ i was very happy to do this @Ocramius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Psalm integration
2 participants