Improve type inference for plugin managers, Drop Interop\Container, Drop PHP 7.3 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump minimum version of PHP to 7.4 - Require most recent direct dependencies - Remove dependency on Interop\Container - Bump dev dependencies - Allow plugins
…nterop\Container with Psr\Container
…e manager is ^3.x
gsteel
added this to In progress
in container-interop/container-interop to psr/container
via automation
Ocramius
approved these changes
Jul 12, 2022
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| namespace Laminas\Router; | |||
|
|
|||
| use Zend\Router\Http\TreeRouteStack; | |||
| use Laminas\ServiceManager\ConfigInterface; | |||
| interface ExceptionInterface | ||
| use Throwable; | ||
|
|
||
| interface ExceptionInterface extends Throwable |
| */ | ||
| class RoutePluginManager extends AbstractPluginManager | ||
| { | ||
| /** | ||
| * Only RouteInterface instances are valid | ||
| * | ||
| * @var string | ||
| * @var class-string |
There was a problem hiding this comment.
not important, but consider that interface-string also exists (AFAIK)
container-interop/container-interop to psr/container
automation
moved this from In progress
to Reviewer approved
Jul 12, 2022
container-interop/container-interop to psr/container
automation
moved this from Reviewer approved
to Done
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ExceptionInterfaceextend fromThrowableRoutePluginManager