Support laminas-code:v4 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filippo Tessarotto <zoeslam@gmail.com>
Signed-off-by: Filippo Tessarotto <zoeslam@gmail.com>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Slamdunk
commented
Jan 8, 2021
CHANGELOG.md
Outdated
| @@ -22,6 +22,8 @@ All notable changes to this project will be documented in this file, in reverse | |||
|
|
|||
| ### Removed | |||
|
|
|||
| - [#23](https://github.com/laminas/laminas-server/pull/23) removes support for laminas-code releases prior to 4.0.0. | |||
There was a problem hiding this comment.
@weierophinney I didn't drop support to laminas-code:v3, see https://github.com/laminas/laminas-server/pull/23/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R23
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Remove unused import statement Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
|
@weierophinney I'd like to land this into my production. It is not my intention to rush you through the upcoming |
|
@Slamdunk |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for a full PHP8 support.
Supersede #21