Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Psalm #57

Merged
merged 3 commits into from
Jul 22, 2022
Merged

Setup Psalm #57

merged 3 commits into from
Jul 22, 2022

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jul 22, 2022

Q A
QA yes

Description

Supersedes #52
Closes #32

@gsteel gsteel added this to the 2.13.0 milestone Jul 22, 2022
@gsteel gsteel added this to To do in Psalm via automation Jul 22, 2022
@Ocramius Ocramius self-assigned this Jul 22, 2022
@Ocramius
Copy link
Member

@gsteel just beware that #56 just got merged - may need another rebase 😅

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: can be merged after rebase + green build

@Ocramius Ocramius assigned gsteel and unassigned Ocramius Jul 22, 2022
simonefuoco and others added 3 commits July 22, 2022 11:16
Fixes laminas#32 - psalm installed and configured
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel merged commit 9f8a607 into laminas:2.13.x Jul 22, 2022
Psalm automation moved this from To do to Done Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Psalm
  
Done
Development

Successfully merging this pull request may close these issues.

Psalm integration
3 participants