Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Psalm to 5.22.x, Re-enable a number of tests #82

Merged
merged 10 commits into from
Mar 8, 2024
Merged

Upgrade Psalm to 5.22.x, Re-enable a number of tests #82

merged 10 commits into from
Mar 8, 2024

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Mar 4, 2024 •
edited
Loading

  • Enables Mongo, MySQL and PgSQL tests
  • Upgrades Psalm
  • Closes Lock file maintenance #78
  • Add BC Check to the matrix
  • Stop ignoring platform reqs

The BC break reported by tooling is actually a problem with Laminas\Stdlib. ArrayObject::offsetGet() has the wrong parameter name.

@gsteel
Fix invalid parameter type
750da58 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Require XDebug, stop ignoring platform reqs and add BC check to matrix
5e3165d 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel added this to the 2.20.0 milestone Mar 4, 2024
@gsteel gsteel marked this pull request as draft March 4, 2024 16:12
@gsteel
Remove redundant env var
c10492e 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Enable mongodb tests
0587363 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Require ext-xdebug in dev and refresh dev deps
dd97654 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Upgrade Psalm to 5.22.x
33d266d 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Enable MySQL tests
913509a 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
CS Fixes
f59b899 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Correct parameter name
c40c8de 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Enable PgSQL tests
580685a 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel changed the title Upgrade Psalm to 5.22.x Upgrade Psalm to 5.22.x, Re-enable a number of tests Mar 4, 2024
@gsteel gsteel marked this pull request as ready for review March 4, 2024 17:40
@gsteel gsteel assigned gsteel and unassigned gsteel Mar 4, 2024
@gsteel gsteel requested a review from a team March 7, 2024 13:54
Ocramius
Ocramius approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gsteel!

@Ocramius
Copy link
Member

Ocramius commented Mar 8, 2024 

[BC] CHANGED: Parameter 0 of Laminas\Stdlib\ArrayObject#offsetUnset() changed name from key to offset
[BC] CHANGED: Parameter 0 of Laminas\Stdlib\ArrayObject#offsetUnset() changed name from key to offset
[BC] CHANGED: Parameter 0 of Laminas\Session\AbstractContainer#offsetUnset() changed name from key to offset
[BC] CHANGED: Parameter 0 of Laminas\Session\AbstractContainer#offsetUnset() changed name from key to offset

We don't really officially support named parameters, AFAIK: this can go in.

@Ocramius Ocramius self-assigned this Mar 8, 2024
@Ocramius Ocramius merged commit 16876aa into laminas:2.20.x Mar 8, 2024
14 of 15 checks passed
@gsteel gsteel deleted the psalm-5.22 branch March 8, 2024 11:57
@gsteel
Copy link
Member Author

gsteel commented Mar 8, 2024

Thanks @Ocramius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
2.20.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsteel @Ocramius