Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add PHP 8 support #13

Merged
merged 2 commits into from Oct 20, 2020
Merged

feat: add PHP 8 support #13

merged 2 commits into from Oct 20, 2020

Conversation

alexraputa
Copy link
Contributor

Q A
New Feature yes

Closes #12

@alexraputa
feat: add PHP 8 support
295e940 
Signed-off-by: Alex Raputa <alexraputa@users.noreply.github.com>
@alexraputa alexraputa marked this pull request as ready for review October 18, 2020 19:11
@boesing boesing added hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com Enhancement labels Oct 20, 2020
@boesing boesing added this to In progress in PHP 8.0 via automation Oct 20, 2020
@boesing boesing added this to the 3.3.0 milestone Oct 20, 2020
boesing
boesing approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@boesing boesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PHP 8.0 automation moved this from In progress to Reviewer approved Oct 20, 2020
@boesing
Add CHANGELOG entry
1947522 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing merged commit fea8fd1 into laminas:3.3.x Oct 20, 2020
PHP 8.0 automation moved this from Reviewer approved to Done Oct 20, 2020
@boesing
Copy link
Member

boesing commented Oct 20, 2020

Thanks, @alexraputa

@alexraputa alexraputa deleted the php8 branch October 20, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boesing boesing boesing approved these changes

Assignees
No one assigned
Labels
Enhancement hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com
Projects
No open projects
PHP 8.0
  
Done
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

PHP 8.0 support
2 participants
@alexraputa @boesing