Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for PHP 8 #4

Merged
merged 10 commits into from Oct 31, 2020
Merged

Conversation

owenvoke
Copy link
Contributor

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Description

This adds support for PHP 8. It looks like Travis doesn't seem to support PHP 8 yet though (I haven't used Travis for ages)?

Closes #3

@rieschl
Copy link

rieschl commented Oct 31, 2020

This adds support for PHP 8. It looks like Travis doesn't seem to support PHP 8 yet though (I haven't used Travis for ages)?

Yes you still have to use nightly.

@owenvoke
Copy link
Contributor Author

Thanks, I've now updated it to use Nightly.

@froschdesign froschdesign linked an issue Oct 31, 2020 that may be closed by this pull request
6 tasks
@froschdesign froschdesign added this to In progress in PHP 8.0 via automation Oct 31, 2020
@froschdesign froschdesign added Enhancement hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com labels Oct 31, 2020
@froschdesign
Copy link
Member

@owenvoke
Thanks for your contribution! 👍
Please look at the related task list for support PHP 8: #3

@owenvoke
Copy link
Contributor Author

I'm following that task list. 👍🏻 Currently on the last one, but it looks like the only issue in the tests is the servicemanager which needs to be updated to a minimum of 3.2.1 as far as I can tell. Is that ok to do? Or do we still need to support 2.x, which doesn't seem to have the changes.

@froschdesign
Copy link
Member

froschdesign commented Oct 31, 2020

I'm following that task list.

You have missed an important task:

Modify composer.json to drop support for PHP less than 7.3

Which also means: remove the old version from the Travis configuration. 😉

composer.json Outdated Show resolved Hide resolved
PHP 8.0 automation moved this from In progress to Review in progress Oct 31, 2020
@owenvoke
Copy link
Contributor Author

owenvoke commented Oct 31, 2020

Ah, makes sense. 🤦🏻 I've removed the old versions, and updated to a minum of Service Manager v3.4, which added PHP8 support (and dropped <7.3). And also now removed the old versions from Travis. 😬 Apologies for forgetting this.

Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
@boesing boesing changed the base branch from develop to 2.8.x October 31, 2020 13:13
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing merged commit 3e8ea9d into laminas:2.8.x Oct 31, 2020
PHP 8.0 automation moved this from Review in progress to Done Oct 31, 2020
@boesing
Copy link
Member

boesing commented Oct 31, 2020

Thanks @owenvoke

@boesing boesing added this to the 2.8.0 milestone Oct 31, 2020
@owenvoke owenvoke deleted the feature/php-8 branch October 31, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com
Projects
No open projects
PHP 8.0
  
Done
Development

Successfully merging this pull request may close these issues.

PHP 8.0 support
4 participants