New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for PHP 8 #4
Conversation
f1996a5
to
afd31e5
Compare
Yes you still have to use |
62b9f3a
to
14addfd
Compare
Thanks, I've now updated it to use Nightly. |
I'm following that task list. 👍🏻 Currently on the last one, but it looks like the only issue in the tests is the |
You have missed an important task:
Which also means: remove the old version from the Travis configuration. 😉 |
Ah, makes sense. 🤦🏻 I've removed the old versions, and updated to a minum of Service Manager v3.4, which added PHP8 support (and dropped <7.3). And also now removed the old versions from Travis. 😬 Apologies for forgetting this. |
Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
Signed-off-by: Owen Voke <development@voke.dev>
4b36fda
to
cfe05f2
Compare
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Thanks @owenvoke |
Description
This adds support for PHP 8. It looks like Travis doesn't seem to support PHP 8 yet though (I haven't used Travis for ages)?
Closes #3