Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial V3 Migration Guide #253

Open
wants to merge 19 commits into
base: 3.0.x
Choose a base branch
from
Open

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jun 12, 2024

@gsteel gsteel added this to the 3.0.0 milestone Jun 12, 2024
@gsteel gsteel marked this pull request as draft June 12, 2024 21:58
@gsteel gsteel force-pushed the v3/migration-guide branch 2 times, most recently from b0ce318 to 7aa7bcf Compare June 26, 2024 08:39
@froschdesign froschdesign linked an issue Jun 26, 2024 that may be closed by this pull request
@gsteel gsteel force-pushed the v3/migration-guide branch 3 times, most recently from ade1457 to 619812e Compare July 5, 2024 12:12
@gsteel
Copy link
Member Author

gsteel commented Jul 24, 2024

@froschdesign - Could you please cast your eyes over this to see if I'm going in the right direction. It's getting pretty big and I'd appreciate a bit of feedback before I put too much more effort into it in case I'm doing a terrible job!!

@froschdesign
Copy link
Member

@gsteel

Could you please cast your eyes over this to see if I'm going in the right direction.

I must apologise, because of course I've looked at every change to this pull request so far, but left you in the dark about it.
The direction is perfect! 👍🏻
I will do another check to make sure that nothing has been forgotten.

@gsteel
Copy link
Member Author

gsteel commented Jul 25, 2024

I must apologise, because of course I've looked at every change to this pull request so far, but left you in the dark about it. The direction is perfect! 👍🏻 I will do another check to make sure that nothing has been forgotten.

Thank you @froschdesign 🙏

@gsteel gsteel marked this pull request as ready for review July 25, 2024 10:38
@gsteel gsteel force-pushed the v3/migration-guide branch 2 times, most recently from 289e1e3 to 285478c Compare July 31, 2024 09:31
@froschdesign
Copy link
Member

@gsteel
Since the question will come up, I'm thinking about what to write to the support of laminas-mvc with version 3?!
The other topic is the database validators. At the moment we are not saying anything about alternatives or offering anything else. 🤔

@gsteel
Copy link
Member Author

gsteel commented Aug 1, 2024

For the DB validators, Given that laminas-db is unmaintained, perhaps we should point people in the direction of Doctrine Module.

If MVC:3 were to receive ServiceManager:4 support, then Validator:3 is theoretically compatible, once Filter, InputFilter, and Form are.

I think we should just state that Validator:3 is not compatible with MVC until SM:4 support is available there - Whether that appears in MVC:3 or MVC:4 is then not Validators' concern (??)

@froschdesign
Copy link
Member

@gsteel
I will think of something and then write about it. You don't have to do that! 😃

Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Also updates the support options section in the hostname docs with the correct option names

Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Copy link
Member Author

gsteel commented Aug 1, 2024

Thanks @froschdesign - I was just actually writing something about DB - This is what I cam up with, but I'll not commit it and leave this up to you:

Laminas\Db Validator Removal

The deprecated "Db" validators that shipped in version 2.0 have been removed. The removed classes are:

  • Laminas\Validator\Db\AbstractDb
  • Laminas\Validator\Db\NoRecordExists
  • Laminas\Validator\Db\RecordExists

There are now no maintained validators that work directly with the laminas-db component.

As laminas-db has been in security-only maintenance mode for quite some time, we recommend that users consider maintained alternatives such as Doctrine DBAL.

The Doctrine Project provides Doctrine Module to integrate with the Laminas ecosystem.

Alternatively, you can extract the laminas-db related validators from the most recent 2.x release, refactor them to be compatible with version 3 of laminas-validator and incorporate them into your own project.

Signed-off-by: George Steel <george@net-glue.co.uk>
@froschdesign
Copy link
Member

froschdesign commented Aug 1, 2024

@gsteel
Do you think it would be a problem to add the Laminas\Db\Adapter\AdapterServiceDelegator for database validators for version 2 in a minor version?
This would allow us to refer to simple use and implementation.

@gsteel
Copy link
Member Author

gsteel commented Aug 1, 2024

Do you mean automatically register the delegator in ConfigProvider and Module?

I have no problem with that - I'm surprised it wasn't done before looking at the docs that you linked!

@froschdesign
Copy link
Member

My current idea:

  • add the delegator for the database validators (v2)
  • add the usage of validators in a laminas-mvc based application to the documentation (v2)
  • add the usage of database validators in forms in a laminas-mvc based application to documentation (v2)
  • add links to application integrations to homepage (v2) - example
  • add a warning when using laminas-mvc to homepage (v3)

@gsteel
Copy link
Member Author

gsteel commented Aug 1, 2024

Sounds like a good plan to me, however, it's a fair bit of work for legacy stuff that people should be migrating away from, even though it will be a clear benefit to users. Is it worth the effort?

@froschdesign
Copy link
Member

The point is quite right, but we don't offer an alternative and then also say that version 3 doesn't work with laminas-mvc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants