Introduce NumberComparison validator #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 20, 2024
Adds a single validator that only validates numeric input with optional lower and upper bounds. This validator should replace `LessThan`, `GreaterThan` and `Between` Signed-off-by: George Steel <george@net-glue.co.uk>
… can be set independently Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
force-pushed
the
v2/number-comparison
branch
from
27f6f97
to
f940307
Compare
Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
force-pushed
the
v2/number-comparison
branch
from
f940307
to
fb05692
Compare
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
force-pushed
the
v2/number-comparison
branch
from
1620cc5
to
fc765ee
Compare
froschdesign
requested changes
Jun 25, 2024
Co-authored-by: Frank Brückner <info@froschdesignstudio.de> Signed-off-by: George Steel <george@netglue.uk>
Ocramius
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a single validator that only validates numeric input with optional lower and upper bounds.
This validator should replace
LessThan,GreaterThanandBetweenFurther discussion on the reason for this validator in #272