QA: Update Github templates + support files #31
Conversation
docs/SUPPORT.md
Outdated
| @@ -1,9 +1,11 @@ | |||
| # Getting Support | |||
|
|
|||
| Laminas offers the following support channels: | |||
| Laminas offers three support channels: | |||
There was a problem hiding this comment.
This is how we have now in migration template, but I think I prefer the previous version.
What do you think, @weierophinney?
There was a problem hiding this comment.
I like "the following" versus "three", because if the quantity of support channels changes, we don't have to change both the list and this preamble.
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| * Bugfix: master branch | ||
| * QA improvement (additional tests, CS fixes, etc.) that does not change code | ||
| behavior: master branch | ||
| * New feature or refactor or existing code: develop branch |
There was a problem hiding this comment.
This is also from template, but there is something wrong - New feature or refactor or existing code.
BTW Do we want develop for refactor that does not change the code behaviour?
There was a problem hiding this comment.
It should read "New feature, or refactor of existing code".
Marco would definitely argue that a refactor is considered a new feature, particularly as it can potentially introduce BC breaks or be used to allow new features to evolve.
No description provided.