Improve performance : count() and array_push removal when possible #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use empty [] comparison instead of count() for array when possible - Use array assign instead of array_push when possible Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
samsonasik
force-pushed
the
improve-performance
branch
from
547a14f
to
0878f55
Compare
samsonasik
changed the title
snapshotpl
approved these changes
Jun 24, 2021
|
@samsonasik |
|
@froschdesign its improvement, not bug fix, if i remember correctly, @Ocramius pointed for improve performance is targetting minor version. |
|
@samsonasik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abdul Malik Ikhsan samsonasik@gmail.com
Description