Allow the composer class loader to be absent, for composer/composer:2.2.0 compatibility
#90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With composer 2.2.0, some autoloaders are loaded even before the `vendor/autoload.php` file is dumped. This leads to installation crashes in some circumstances due to the fact that this component throws a `RuntimeException` in case the autoloader could not be found. Due to the fact, that this works properly after the autoloader got dumped, we can safely not register the prepend/append autoloader registration for this case. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
This was referenced Dec 21, 2021
Closed
Ocramius
approved these changes
Dec 21, 2021
…calls Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
bugfix/handle-not-existing-autoloader
branch
from
916d5a1
to
e71bcbb
Compare
Ocramius
approved these changes
Dec 21, 2021
Will see if that works after we created release. Actually quite tough to test this without having a "stable" release due to the fact that manipulating Since we are getting rid of this component anyways, I think this bugfix should do its trick. |
|
We can release right away, unless other patches are needed |
|
Looks good to me too for as much as I'm familiar with this code.. At least the intent sounds good :) |
internalsystemerror
approved these changes
Dec 21, 2021
Ocramius
changed the title
composer/composer:2.2.0 compatibility
weierophinney
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With composer 2.2.0, some autoloaders are loaded even before the
vendor/autoload.phpfile is dumped.This leads to installation crashes in some circumstances due to the fact that this component throws a
RuntimeExceptionin case the autoloader could not be found.Due to the fact, that this works properly after the autoloader got dumped, we can safely not register the prepend/append autoloader registration for this case.
Closes #89