Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Introduce local_storage mode for cloud instances #728

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Conversation

@falexwolf falexwolf changed the title 🚚 Rename is_hybrid to mode_is_hybrid 🚚 Rename StorageSettings.is_hybrid to StorageSettings.mode_is_hybrid Apr 23, 2024
@falexwolf falexwolf changed the title 🚚 Rename StorageSettings.is_hybrid to StorageSettings.mode_is_hybrid 🚚 Rename .is_hybrid to .mode_is_hybrid Apr 23, 2024
Copy link

github-actions bot commented Apr 23, 2024

@github-actions github-actions bot temporarily deployed to pull request April 23, 2024 15:03 Inactive
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 93.87755% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.76%. Comparing base (af6100e) to head (2d73141).
Report is 1 commits behind head on main.

❗ Current head 2d73141 differs from pull request most recent head 9465a2d. Consider uploading reports for the commit 9465a2d to get more accurate results

Files Patch % Lines
lamindb_setup/_migrate.py 33.33% 2 Missing ⚠️
lamindb_setup/core/django.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
- Coverage   81.29%   80.76%   -0.53%     
==========================================
  Files          39       39              
  Lines        2523     2548      +25     
==========================================
+ Hits         2051     2058       +7     
- Misses        472      490      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request April 23, 2024 15:28 Inactive
@falexwolf falexwolf changed the title 🚚 Rename .is_hybrid to .mode_is_hybrid 🚚 Rename .is_hybrid to .local_storage Apr 23, 2024
@github-actions github-actions bot temporarily deployed to pull request April 23, 2024 17:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 23, 2024 18:55 Inactive
@falexwolf falexwolf changed the title 🚚 Rename .is_hybrid to .local_storage ✨ Introduce local_storage mode Apr 23, 2024
@falexwolf falexwolf changed the title ✨ Introduce local_storage mode ✨ Introduce local_storage mode for cloud instances Apr 23, 2024
@Koncopd
Copy link
Member

Koncopd commented Apr 23, 2024

I guess local instances also should have local storage, but it should be the same as root. Right?

@falexwolf
Copy link
Member Author

I guess local instances also should have local storage, but it should be the same as root. Right?

Yes! The naming choice is slightly confusing for local instances, but simpler than saying "hybrid" for cloud instances.

The point is to make it easy for users to keep their data local also when working with cloud instances.

They'll have a switch on the hub called "Keep data local" or "Default to local storage" or similar.

I'm pretty sure we'll not allow to have purely local instances on the hub going forward.

@falexwolf falexwolf merged commit 6470ae9 into main Apr 23, 2024
5 checks passed
@falexwolf falexwolf deleted the hybrid branch April 23, 2024 21:22
@github-actions github-actions bot temporarily deployed to pull request April 23, 2024 21:26 Inactive
@Koncopd
Copy link
Member

Koncopd commented Apr 24, 2024

It is not actually clear than what is the difference between local and cloud now. Because a local instance can change its root to cloud but the local storage stays the same i guess. So now every instance can have cloud storage and local storage. So there is not much difference i suppose.

@falexwolf
Copy link
Member Author

It is not actually clear than what is the difference between local and cloud now. Because a local instance can change its root to cloud but the local storage stays the same i guess. So now every instance can have cloud storage and local storage. So there is not much difference i suppose.

You are correct. I'm simply trying to achieve a more convenient UX for users who want to default to local storage working on a common server. I'll give this yet another refactor because the UX is still confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants