-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Introduce local_storage
mode for cloud instances
#728
Conversation
StorageSettings.is_hybrid
to StorageSettings.mode_is_hybrid
StorageSettings.is_hybrid
to StorageSettings.mode_is_hybrid
.is_hybrid
to .mode_is_hybrid
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
- Coverage 81.29% 80.76% -0.53%
==========================================
Files 39 39
Lines 2523 2548 +25
==========================================
+ Hits 2051 2058 +7
- Misses 472 490 +18 ☔ View full report in Codecov by Sentry. |
.is_hybrid
to .mode_is_hybrid
.is_hybrid
to .local_storage
.is_hybrid
to .local_storage
local_storage
mode
local_storage
modelocal_storage
mode for cloud instances
I guess local instances also should have local storage, but it should be the same as root. Right? |
Yes! The naming choice is slightly confusing for local instances, but simpler than saying "hybrid" for cloud instances. The point is to make it easy for users to keep their data local also when working with cloud instances. They'll have a switch on the hub called "Keep data local" or "Default to local storage" or similar. I'm pretty sure we'll not allow to have purely local instances on the hub going forward. |
It is not actually clear than what is the difference between local and cloud now. Because a local instance can change its root to cloud but the local storage stays the same i guess. So now every instance can have cloud storage and local storage. So there is not much difference i suppose. |
You are correct. I'm simply trying to achieve a more convenient UX for users who want to default to local storage working on a common server. I'll give this yet another refactor because the UX is still confusing. |
https://www.notion.so/laminlabs/Data-sharing-through-hybrid-local-remote-LaminDB-instances-e01025ed0e3e4f06948c4390894f20a8
Replace the initial draft:
Needs: