Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 new computes: chunk/spread/atom and reduce/chunk #1089

Merged
merged 6 commits into from Sep 12, 2018
Merged

2 new computes: chunk/spread/atom and reduce/chunk #1089

merged 6 commits into from Sep 12, 2018

Conversation

sjplimp
Copy link
Contributor

@sjplimp sjplimp commented Aug 31, 2018

Purpose

New compute chunk/spread/atom and compute reduce/chunk commands.

Author(s)

Steve

Backward Compatibility

N/A

Implementation Notes

Example code is provided in the 2 doc pages which can be added to bench/in.chain
and examples/micelle/in.micelle which illustrate how to use the new commands.

Post Submission Checklist

Please check the fields below as they are completed

  • The feature or features in this pull request is complete
  • Suitable new documentation files and/or updates to the existing docs are included
  • One or more example input decks are included
  • The source code follows the LAMMPS formatting guidelines

Further Information, Files, and Links

Put any additional information here, attach relevant text or image files, and URLs to external sites (e.g. DOIs or webpages)

@sjplimp
Copy link
Contributor Author

sjplimp commented Aug 31, 2018

@akohlmey I think the one line I deleted in the last commit in fix ave/chunk should not be set,
since it does not produce peratom output. Am I missing some logical need for it?

@akohlmey
Copy link
Member

akohlmey commented Sep 2, 2018

@sjplimp won't be able to look into this for a while. Starting the LAMMPS tutorial in Indonesia tomorrow.

@akohlmey
Copy link
Member

@sjplimp i suspect that the variable initialization you removed was done to avoid some uninitialized variable access error. i think you are correct to remove the line, but those xxx_freq variables should be initialized in fix.cpp instead. Since those are commonly used with the % operator, they are best initialized to -1 instead of 0, to avoid division by zero and have the operation result 0.

@akohlmey akohlmey assigned rbberger and unassigned akohlmey Sep 11, 2018
Copy link
Member

@akohlmey akohlmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few, mostly cosmetic changes

@rbberger rbberger merged commit 6ae4bde into master Sep 12, 2018
@rbberger rbberger deleted the spread branch September 12, 2018 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants