New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove REAX and MEAM packages #1254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this change.
not sure why i had to trigger the rebuild multiple times and only the merge conflict resolve did the trick to have the rebuild work without a failure and also handle the merge conflict. 👎 |
@akohlmey applied some new settings to the PR builder. That should avoid this issue. |
Purpose
This pull request fixes #1129 by implementing the changes listed in the issue and removing the MEAM and REAX packages from LAMMPS. The packages were discouraged from use for a while already.
Author(s)
Axel Kohlmeyer (Temple U)
Backward Compatibility
Inputs with
pair_style reax
commands will be given a message pointing out the last LAMMPS version that contained this pair style. They need to change the syntax to accommodate thepair_style reax/c
syntax (and have to have the USER-REAXC package installed). Inputs withpair_style meam
commands will be redirected transparently to thepair_style meam/c
, provided the USER-MEAMC package is installed.Implementation Notes
For details, please see issue #1129
Post Submission Checklist
Please check the fields below as they are completed