Collected small changes for the next patch release #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junghans
reviewed
Mar 6, 2019
| if(GIT_FOUND) | ||
| execute_process(COMMAND ${GIT_EXECUTABLE} describe HEAD | ||
| RESULT_VARIABLE temp_in_git_checkout | ||
| if(GIT_FOUND AND EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/../.git) |
There was a problem hiding this comment.
The other option and maybe the safer one would be to do ${GIT_EXECUTABLE} -C ${CMAKE_CURRENT_SOURCE_DIR}/../.git everywhere.
There was a problem hiding this comment.
In case you were wondering of using IS_DIRECTORY instead of EXISTS, this was on purpose, as git submodules only have .git file not a directory. And lammps is used as a submodule e.g. in: https://gitlab.com/exaalt/exaalt
…ies resulting in segfaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request combines multiple small changes and bugfixes
Related Issues
implements a suggestion from the discussion of #1357
fixes #1362
Author(s)
Axel Kohlmeyer (Temple U)
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
yes.
Implementation Notes
The following individual changes are implemented:
groupcommand options that access unavailable atom attributes.Post Submission Checklist
Please check the fields below as they are completed after the pull request has been submitted
Further Information, Files, and Links
Put any additional information here, attach relevant text or image files, and URLs to external sites (e.g. DOIs or webpages)