Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed TEMPLATED_FIX_LANGEVIN ifdef and untemplated version of fix langevin #1562

Merged
merged 1 commit into from Jul 12, 2019

Conversation

athomps
Copy link
Contributor

@athomps athomps commented Jul 12, 2019

Summary

The templated implementation of FixLangevin::post_force supports many options efficiently and is not causing any problems. Therefore, the untemplated version is no longer needed and has been removed. One less ifdef.

Related Issues

Author(s)

Aidan Thompson

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

No

Implementation Notes

None

Post Submission Checklist

Please check the fields below as they are completed after the pull request has been submitted. Delete lines that don't apply

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • A package specific README file has been included or updated
  • One or more example input decks are included

Further Information, Files, and Links

Put any additional information here, attach relevant text or image files, and URLs to external sites (e.g. DOIs or webpages)

@akohlmey akohlmey self-assigned this Jul 12, 2019
@akohlmey akohlmey added this to the Stable Release Summer 2019 milestone Jul 12, 2019
@akohlmey akohlmey merged commit 61220f9 into lammps:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants