Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle conflict between conventional build and CMake build in lib/gpu #2135

Merged
merged 4 commits into from Jun 9, 2020

Conversation

akohlmey
Copy link
Member

@akohlmey akohlmey commented Jun 9, 2020

Summary

When compiling the GPU package with CUDA, it will silently pick up inconsistent cubin header files from the lib/gpu folder that were left over from a legacy compile and thus may cause kernels to fail, if there is a mismatch. This PR adds a check for those and prints and error message if found and a suggested command to remove them.

Author(s)

Axel Kohlmeyer, Temple U

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

Yes.

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the CMake based build system

… set

This resolves issues such as CUDA_CUDA_LIBRARY NOTFOUND if LIBRARY_PATH is
set to the CUDA stubs folder, but ignored by CMake.
@akohlmey akohlmey merged commit 7199365 into lammps:master Jun 9, 2020
@akohlmey akohlmey deleted the cmake-legacy-gpu-conflict branch June 9, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants