Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pair style for charge-dipole damping with Tang-Toennies function #2389

Merged
merged 10 commits into from
Oct 8, 2020

Conversation

kateryna-goloviznina
Copy link
Contributor

@kateryna-goloviznina kateryna-goloviznina commented Sep 22, 2020

Summary

This is a new pair style to damp Coulomb charge-dipole interactions with the Tang-Toennies (TT) function. It allows preventing a "polarisation catastrophe" happening when strongly H-bonded systems are simulated. The pair style will be included in the USER-DRUDE package.

Related Issue(s)

Author(s)

Kateryna Goloviznina* kate.goloviznina@gmail.com, ENS de Lyon
Zheng Gong, z.gong@outlook.com, ENS de Lyon
Agilio Padua* agilio.padua@gmail.com, ENS de Lyon

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

Implementation Notes

The pair style is called coul/tt and should be used in conjunction with a main pair style including Coulomb interactions and thole pair style, or with lj/cut/thole/long equivalent to the combination of preceding two.

The coul/tt modifies the Coulomb interactions between a Drude charge (either qD,i on a Drude particle or -qD,i on the respective Drude core) and a charge on a non-polarizable atom, qj. It is also possible to use this pair style to damp charge-dipole interactions between Drude cores.

The damping function was tested on several systems containing strong hydrogen bonds (solvents, ionic liquids, electrolytes) and allowed to obtain stable trajectories. The example of simulating ethylene glycol is included.

The added damping function will not affect any existing functionality.

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • Suitable tests have been added to the unittest tree.
  • A package specific README file has been included or updated
  • One or more example input decks are included

Further Information, Files, and Links

Application of the Tang-Toennies function to damp electrostatic interactions in molten salts 10.1007/s00214-012-1143-9
The use of this function for strongly H-bonded systems will be described in our future paper. preprint

Copy link
Member

@akohlmey akohlmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that we are in the final stage of getting ready for a stable release, so this PR likely will have to wait until after (unless there are delays postponing the stable release and adding one more patch release).

src/USER-DRUDE/pair_coul_tt.h Outdated Show resolved Hide resolved
src/USER-DRUDE/pair_coul_tt.cpp Outdated Show resolved Hide resolved
src/USER-DRUDE/pair_coul_tt.cpp Outdated Show resolved Hide resolved
examples/USER/drude/ethylene_glycol/data.eg.lmp Outdated Show resolved Hide resolved
@kateryna-goloviznina
Copy link
Contributor Author

kateryna-goloviznina commented Sep 25, 2020

Thank you for the revision of my code! Yes, I understand that it will go to the winter stable version.

I still need some time to finish editing the code.

@akohlmey akohlmey self-requested a review September 28, 2020 17:58
@akohlmey akohlmey dismissed their stale review September 28, 2020 17:59

Requested changes have been implemented

@akohlmey
Copy link
Member

@kateryna-goloviznina i have corrected the string matching issues and did a few more cosmetic changes as well as integrating the .rst file fully into the documentation build process.

@kateryna-goloviznina
Copy link
Contributor Author

@akohlmey Thank you for your help!

@akohlmey akohlmey merged commit 4a85614 into lammps:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants