New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Programmer Guide and Library Interface updates for next release #2413
Conversation
|
||
pip3 install virtualenv | ||
pip3 install virtualenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should think about updating this to the venv
module that is part of Python 3. That way we avoid having to install virtualenv
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't be able to do this in this PR. too many ripples.
@@ -1,6 +1,7 @@ | |||
// unit tests creating LAMMPS instances via the library interface | |||
|
|||
#include "lammps.h" | |||
#define LAMMPS_LIB_MPI 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
… we are initialized.
…on-periodic boundaries
Summary
This contains various updates to the Programmer Guide, the library interfaces, the python module, CMake scripts, and the LAMMPS shell in preparation for the stable release.
Author(s)
Axel Kohlmeyer, Temple U
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
The
-DLAMMPS_LIB_NO_MPI
has been replaced with-DLAMMPS_LIB_MPI
and the meaning is now reversed.Implementation Notes
Individual changes are:
Post Submission Checklist