Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new utils::strfind() function and update mini-regex code #2632

Merged
merged 5 commits into from Feb 26, 2021

Conversation

akohlmey
Copy link
Member

Summary

This updates the mini-regex code in the utils namespace to the current version with a few portability and bug fixes and indication of the length of a match. The latter is needed for the new utils::strfind() function that may replace the use of (not yet) fully portable use of std::regex across our range of supported machines.

Related Issue(s)

Needed for PR #2625

Author(s)

Axel Kohlmeyer, Temple U

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

No known issues. Existing unit tests for utils::strmatch() pass.

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • Suitable tests have been added to the unittest tree.

Further Information, Files, and Links

https://github.com/kokke/tiny-regex-c

@akohlmey akohlmey added this to the Stable Release Spring 2021 milestone Feb 26, 2021
@akohlmey akohlmey self-assigned this Feb 26, 2021
@akohlmey akohlmey merged commit aea0cea into lammps:master Feb 26, 2021
@akohlmey akohlmey deleted the utils-regex-update branch February 26, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants