-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replicate periodic box #3118
Replicate periodic box #3118
Conversation
generalizes the command to work for periodic systems
@jrgissing I pushed the folllowing minor changes: If all this looks good to you, I can approve the PR and it should be ready to merge. |
@sjplimp this looks good to me! |
@stanmoore1 I think this should be ready for you to look at and merge. |
Summary
implement generalized algorithm for replicate command, to correctly replicate molecules that are looped across periodic boundaries
Related Issue(s)
none
Author(s)
JG
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
yes
Implementation Notes
several tricky parts to this feature. first was issues in serial, including literal corner case when bonded interactions are looped in multiple dimensions. second was issues in parallel, used existing infrastructure from 'bbox' option to get system-wide info
does not actually walk bond list, instead utilizes self-consistent minimum image convention of replicated box. may not work for very small systems where bonded interaction is greater than half of original box length (which lammps already complains about).
tested with system that has pre-existing image flags
Post Submission Checklist
Further Information, Files, and Links