Neighbor fixes #335
Merged
Neighbor fixes #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #333. |
|
This bugfix does not resolve the crash I reported on the list in relation to examples/USER/misc/srp |
|
strange. it fixes it for me. did you do a "make package-update" after pulling the branch? |
|
Dear Axel,
Indeed very strange. I couldn't merge the pull request, apparently write
access to the stanmoore1:neighbor_fixes branch is required for this.
However, I manually ported the changes (just a few lines). Checked
correctness with git diff vs. "files changed" on github, did make pu,
recompiled, and reproduced the same crash.
…--
Mvh. Carsten
|
|
OK, you are correct. while the input runs on my machine, valgrind is still unhappy and complaining about illegal accesses. i've looked a bit closer and found a couple of bugs in fix srp and one issue in the neighbor list build during the setup phase of a run. |
|
My proposed changes are now available in #339 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs in neighborlist code