Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix style pimd/langevin #3660

Merged
merged 70 commits into from Jun 7, 2023
Merged

Add fix style pimd/langevin #3660

merged 70 commits into from Jun 7, 2023

Conversation

Yi-FanLi
Copy link
Collaborator

@Yi-FanLi Yi-FanLi commented Feb 24, 2023

Summary

This PR adds a new fix style pimd/langevin.
It renamed the fix style proposed in #3625

It is intended to add the following features:

stochastic thermostat
isotropic / anisotropic barostat (and triclinic in the future)
multi-processing for each bead
well-optimized inter-replica communication and synchronization scheme to guarantee speed
a set of post-processing code to calculate the quantum estimators

Author(s)

Yifan Li
Graduate Student
Department of Chemistry, Princeton University
yifanl0716@gmail.com

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

N/A

Implementation Notes

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • One or more example input decks are included

Further Information, Files, and Links

TODO list for making the pull request ready for review

  • remove all dead code, unused keywords, unused class members, commented out code
  • update the documentation:
  • all supported keywords and features are documented
  • there is no documentation for not yet implemented features
  • add section that discusses the differences between fix pimd/nvt and fix pimd/langevin
  • add a few small examples demonstrating the use of the command and some options
  • remove all memory leaks:
  • deallocate all allocated arrays in destructor
  • delete all created classes in destructor
  • delete all added communicators in destructor
  • delete allocated storage before (re)allocating (requires initialization of pointers in with nullptr in constructor)
  • there must be no uninitialized memory accesses (check with valgrind, same for memory leaks)

@Yi-FanLi
Copy link
Collaborator Author

Hi @akohlmey and @athomps , I have renamed the fix style pimd to pimd/langevin based on your suggestions.

@Yi-FanLi Yi-FanLi marked this pull request as ready for review March 31, 2023 07:29
@Yi-FanLi Yi-FanLi requested a review from sjplimp as a code owner March 31, 2023 07:29
@Yi-FanLi Yi-FanLi requested a review from akohlmey March 31, 2023 07:29
@sjplimp
Copy link
Contributor

sjplimp commented Apr 3, 2023

I approved this - thanks for submitting and separating it into two commands. But I defer to @akohlmey on the implementation details.

@Yi-FanLi
Copy link
Collaborator Author

Yi-FanLi commented Apr 9, 2023

@akohlmey Hi Axel, could you please take a look at your convenience? Thanks a lot!

Copy link
Member

@akohlmey akohlmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are only some minor, cosmetic changes. Changing kBT is optional. Otherwise, this looks ready to merge.

src/REPLICA/fix_pimd_langevin.cpp Outdated Show resolved Hide resolved
src/REPLICA/fix_pimd_langevin.cpp Outdated Show resolved Hide resolved
src/REPLICA/fix_pimd_langevin.cpp Outdated Show resolved Hide resolved
doc/src/fix_pimd.rst Outdated Show resolved Hide resolved
@Yi-FanLi Yi-FanLi requested a review from akohlmey June 6, 2023 22:18
@akohlmey akohlmey merged commit 74a9cfc into lammps:develop Jun 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants