Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collected small changes and fixes #3725

Merged
merged 21 commits into from
Apr 10, 2023

Conversation

akohlmey
Copy link
Member

@akohlmey akohlmey commented Apr 6, 2023

Summary

This pull request combines multiple small sets of changes to fix issues or refactor/update code and documentation

Related Issue(s)

N/A

Author(s)

Axel Kohlmeyer, Temple U

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

N/A

Implementation Notes

The following individual changes are included:

  • integrate cross-compilation of Plumed2 lib for enabling PLUMED package support for Windows
  • handle changes in Linux distribution naming to correctly detect newer versions of Fedora Linux
  • detect even faster "mold" linker when testing is enabled on top of "gold" and "lld".
  • Update KOKKOS compilation docs since nvcc_wrapper no longer needs to be set as C++ compiler with KOKKOS/CUDA
  • fix copy-n-paste issue in fix wall/gran docs
  • some reformatting with clang-format
  • silence compiler warnings
  • improve error messages in some region commands

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system

@akohlmey akohlmey marked this pull request as ready for review April 10, 2023 13:53
@akohlmey akohlmey merged commit ff5b4e9 into lammps:develop Apr 10, 2023
@akohlmey akohlmey deleted the collected-small-changes branch April 10, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants