Fix compile error with latest Kokkos develop branch
#3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to Christian, this may be an unintended change in Kokkos, see kokkos/kokkos#6066. |
|
It sounds like this may not be fixed in Kokkos for a while (if ever). |
sjplimp
approved these changes
Apr 19, 2023
akohlmey
approved these changes
Apr 19, 2023
This change looks like a good change, regardless. If you can use a const reference it is always preferred over a non-const reference. This is one of the things that clang-tidy suggests, for example, if it sees an opportunity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix compile error with latest Kokkos lib, reported by Nick Curtis (AMD), @arghdos
Related Issue(s)
#3670
Author(s)
Stan Moore (SNL)
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
Yes