Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collected small changes and fixes #3763

Merged
merged 19 commits into from
May 5, 2023

Conversation

akohlmey
Copy link
Member

@akohlmey akohlmey commented May 2, 2023

Summary

This pull request combines multiple small changes and fixes

Related Issue(s)

N/A

Author(s)

Axel Kohlmeyer, Temple U

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

No known issues

Implementation Notes

The following individual changes are included:

  • improved error messages for fix nvt/npt/nph
  • show alternate formulation of 12-6 LJ potential using the minimum energy (r_0) instead of sigma
  • suppress a bogus warning in {fmt} with gcc 13+
  • avoid integer overflow in phonon tool
  • improve error messages and modernize compute pressure
  • avoid uninitialized data access for computes
  • improve error messages for fix_modify
  • includes PR Fix Markdown table in tools/tabulate/README.md #3757

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system

@akohlmey akohlmey marked this pull request as ready for review May 3, 2023 08:26
@akohlmey akohlmey requested a review from sjplimp as a code owner May 3, 2023 08:26
@akohlmey akohlmey requested a review from stanmoore1 May 3, 2023 08:26
@sjplimp
Copy link
Contributor

sjplimp commented May 3, 2023

Pair lj seems like the natural place. You could also look at the Howto pages on force fields - maybe 8.4.1 -
if this Q is related to other bio force fields.

@akohlmey akohlmey added the bugfix label May 3, 2023
@akohlmey akohlmey merged commit b3130a2 into lammps:develop May 5, 2023
4 checks passed
@akohlmey akohlmey deleted the collected-small-fixes branch May 5, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants