Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collected small changes and fixes #3855

Merged
merged 10 commits into from
Jul 17, 2023

Conversation

akohlmey
Copy link
Member

@akohlmey akohlmey commented Jul 15, 2023

Summary

This pull request combines multiple small fixes and changes

Related Issue(s)

fixes #3854

Author(s)

Axel Kohlmeyer, Temple U

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

No known issues.

Implementation Notes

The following individual changes are included:

  • update VIM syntax highlighting for LAMMPS input files
  • fix of an off-by-one bug when parsing the optional argument of the temper/npt command
  • fixes to address static code analysis issues in selected files
  • coding style improvement and code modernization in selected files
  • small corrections and style improvements in the manual

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • Suitable tests have been added to the unittest tree.
  • A package specific README file has been included or updated

@akohlmey akohlmey added this to the Stable Release Summer 2023 milestone Jul 15, 2023
@akohlmey akohlmey self-assigned this Jul 15, 2023
@akohlmey akohlmey marked this pull request as ready for review July 17, 2023 04:51
@akohlmey akohlmey requested a review from sjplimp as a code owner July 17, 2023 04:51
src/REPLICA/temper.h Outdated Show resolved Hide resolved
@akohlmey akohlmey merged commit dba4d9e into lammps:develop Jul 17, 2023
4 checks passed
@akohlmey akohlmey deleted the collected-small-changes branch July 17, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] _temper/npt restart index
3 participants