Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fine grained monitoring if computes were initialized #3865

Merged
merged 6 commits into from
Jul 21, 2023

Conversation

akohlmey
Copy link
Member

@akohlmey akohlmey commented Jul 21, 2023

Summary

This updates and refactors the changes from PR #3771 to handle cases of computes being created after a run.

Author(s)

Axel Kohlmeyer and Steve Plimpton, Temple U

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

N/A

Implementation Notes

This introduces a flag inside the Compute class that tracks whether the compute was initialized by a run or minimize or something else that calls Modify::init(). This flag can be queried with a new Compute::is_initialized() method.

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • Suitable tests have been added to the unittest tree.
  • A package specific README file has been included or updated
  • One or more example input decks are included

@akohlmey akohlmey self-assigned this Jul 21, 2023
src/thermo.cpp Outdated Show resolved Hide resolved
src/reset_atoms_image.cpp Outdated Show resolved Hide resolved
@akohlmey akohlmey marked this pull request as ready for review July 21, 2023 15:29
@akohlmey akohlmey merged commit a4a206e into develop Jul 21, 2023
7 checks passed
@akohlmey akohlmey deleted the compute-init-flags branch July 21, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants