Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collected small changes and fixes #3937

Merged
merged 23 commits into from Oct 13, 2023

Conversation

akohlmey
Copy link
Member

@akohlmey akohlmey commented Oct 11, 2023

Summary

This pull request combines multiple small changes and bug fixes that do not warrant individual pull requests

Related Issue(s)

N/A

Author(s)

Axel Kohlmeyer, Temple U

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

N/A

Implementation Notes

The following individual changes are included:

  • avoid segfault in multi-threaded neighbor lists, if the number of threads has been reduced during the executable run (e.g. when using LAMMPS GUI)
  • small doc updates for fix srd, pair style reaxff, and pair style tmd/ilp
  • port of LAMMPS GUI to Qt6
  • replace entire word under cursor with auto-completion
  • avoid infinite loop in StdCapture and instead time out after one second
  • avoid multiple out of bounds memory accesses in LAMMPS GUI detected by compiling to Qt with assertions enabled
  • auto detect OpenMP availability when compiling LAMMPS GUI as standalone executable

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • Suitable tests have been added to the unittest tree.
  • A package specific README file has been included or updated
  • One or more example input decks are included

@stanmoore1 stanmoore1 requested review from oywg11 and stanmoore1 and removed request for oywg11 October 12, 2023 15:06
lib/pace/Makefile Outdated Show resolved Hide resolved
@akohlmey akohlmey marked this pull request as ready for review October 13, 2023 15:12
Copy link
Contributor

@stanmoore1 stanmoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve

@akohlmey akohlmey merged commit 14af16e into lammps:develop Oct 13, 2023
4 checks passed
@akohlmey akohlmey deleted the collected-small-changes branch October 13, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants