New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU package updates Dec 2023 #4009
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gpu-cuda, added "comm_modify vel yes" to in.mdpd
akohlmey
added
gpu_unit_tests
Enable to trigger GPU unit tests
and removed
gpu_unit_tests
Enable to trigger GPU unit tests
labels
Dec 11, 2023
akohlmey
added
gpu_unit_tests
Enable to trigger GPU unit tests
and removed
gpu_unit_tests
Enable to trigger GPU unit tests
labels
Dec 11, 2023
akohlmey
added
gpu_unit_tests
Enable to trigger GPU unit tests
and removed
gpu_unit_tests
Enable to trigger GPU unit tests
labels
Dec 12, 2023
akohlmey
added
test_runs
Enable to trigger run tests
test_for_regression
Enable to trigger regression tests
gpu_unit_tests
Enable to trigger GPU unit tests
and removed
test_runs
Enable to trigger run tests
test_for_regression
Enable to trigger regression tests
gpu_unit_tests
Enable to trigger GPU unit tests
labels
Dec 12, 2023
stanmoore1
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update Commands list, https://github.com/lammps/lammps/blob/develop/doc/src/Commands_pair.rst. Otherwise looks fine to me.
@stanmoore1 thanks, I updated |
akohlmey
added
gpu_unit_tests
Enable to trigger GPU unit tests
and removed
gpu_unit_tests
Enable to trigger GPU unit tests
labels
Dec 13, 2023
akohlmey
approved these changes
Dec 13, 2023
stanmoore1
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains updates and maintenance to the GPU package: adding the GPU version of several pair styles: lj/cut/coul/long/soft, lj/cut/coulcut/soft, coul/long/slater, edpd, mdpd, sph/lj, sph/taitwater, sph/heatconduction; updating the corresponding doc pages, and cleaning up unused variables.
Related Issue(s)
coul/long/slater is added per Feature Request and thus closes #3918
Author(s)
Trung Nguyen (U Chicago)
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
Should maintain backward compatibility
Implementation Notes
The pair styles from DPD-MESO and SPH packages demonstrate how to use the extra arrays to store extra_field per-atom data in the GPU package, and how to accumulate/tally per-atom values within the kernels. This is an option to refactor existing Base* classes and to support other AtomVec* classes with extra per-atom data.
The pair styles mdpd_rhosum and sph_heatconduction do not calculate atom forces, energy and virial, but rather tallying per-atom values, which are reminiscent of computing density rho in pair eam, and so can be lumped into the actual pair styles.
Post Submission Checklist
Further Information, Files, and Links