-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for the ELECTRODE package #4095
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjplimp
requested changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all looks good - just add the sentence to the README we talked about with info on the CMake keyword
sjplimp
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The directory 'src/ELECTRODE' was lacking a README file which is now added.
If an electrode fix uses a matrix of interactions, atoms in the electrode must not move. The fix now checks for time integrating fixes and a warning is given if electrode atoms are in the groups of these fixes.
A new keyword for the electrode fixes is added which allows to set a constraint on the total charge of all electrodes to a given value or equal style variable. This can be used to assert charge neutrality of the simulation if the electrolyte is not charge neutral or not all electrodes are included in the electrode fix.
A new keyword for the electrode fixes is added which allows to set the eta parameter for individual atoms via a property/atom fix.
Related Issue(s)
Author(s)
Ludwig Ahrens-Iwers (@ludwig-ahrens)
Shern Tee (@srtee) (s.tee@griffith.edu.au)
Robert Meißner (@robeme) (robert.meissner@tuhh.de)
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
Changes are backwards compatible.
Implementation Notes
For the matrix inversioin 'update_psi_qtotal()' has been added to shift the potential to obtain electrodes with a total charge of qtotal. For the conjugate gradient the method 'constraint_correction()' was changed to project into a hyperplane with the desired total charge.
The keyword uses the new 'find_custom_ghost()' method to find a property/atom which uses the 'ghost on' option. If the keyword is used, the ElectrodeMatrix and ElectrodeVector classes have to use the atom property for calculations of the interactions.
Post Submission Checklist
Further Information, Files, and Links