Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for processors grid numa style #4097

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

wmbrownIntel
Copy link
Collaborator

As core counts per socket and data movement bottlenecks increase, it can be better to optimize the numa mapping within a node. This adds a processors option to specify the number of numa domains for the processors grid numa style, with the default being 2. It also simplifies the numa mapping algorithm with more aggressive optimization to reduce comm between numa domains.

Summary

Related Issue(s)

Author(s)

Mike Brown, Intel

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

I chose the numa domains option to be a separate keyword for processors, preserving backward compatibility. Of course, the other option, that might be more natural to the LAMMPS command style but break compatibility, would be to make this an argument for 'numa'.

Implementation Notes

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • Suitable tests have been added to the unittest tree.
  • A package specific README file has been included or updated
  • One or more example input decks are included

Further Information, Files, and Links

…e, simplify numa mapping with more agressive optimization to reduce comm between numa domains.
Copy link
Contributor

@stanmoore1 stanmoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I approve. Thanks @wmbrownIntel

Copy link
Contributor

@sjplimp sjplimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Mike

@akohlmey akohlmey assigned akohlmey and unassigned sjplimp Mar 7, 2024
@akohlmey akohlmey merged commit bd99c2d into lammps:develop Mar 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants