More consistent checking on lengths of variable-length vectors and arrays #4122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Global vectors produced by computes, fixes, and vector-style variables can be variable-length, with the length sometimes not known until run time. Likewise global arrays produced by computes and fixes can have a variable number of rows. When
these quantities are output or used in variable formulas, some checking needs to be done to ensure elements of the vectors
or rows of the arrays are correctly accessed. In the case of vector-style variables some commands allow for access beyond
the (unknown) length by returning zero values. This PR simply tries to make all of this error checking more consistent.
Related Issue(s)
A previous PR #4098 flagged an issue which led to this more comprehensive PR.
Author(s)
Steve
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
Hopefully this PR will only flag input script syntax errors that could have previously been allowed.
Implementation Notes
Post Submission Checklist
Further Information, Files, and Links