Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collected small changes #4146

Merged
merged 9 commits into from
May 13, 2024
Merged

Conversation

akohlmey
Copy link
Member

@akohlmey akohlmey commented Apr 24, 2024

Summary

The pull request addresses multiple small issues

Related Issue(s)

N/A

Author(s)

Axel Kohlmeyer, Temple U

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

Pair style meam/c is no longer an accepted alias for pair style meam

Implementation Notes

The following individual changes are includes:

  • updates to github workflow on macOS to workaround recent failures with pip install
  • downgrade from macos-latest to macos-13 due to compiler optimization issues with unit tests
  • update to unit test to capture command errors
  • update version.h file to flag development version
  • remove backward compatibility for pair style meam/c
  • update OpenCL loader sources to latest release

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • Suitable tests have been added to the unittest tree.

@akohlmey akohlmey marked this pull request as ready for review April 24, 2024 07:51
@akohlmey akohlmey requested a review from sjplimp as a code owner April 24, 2024 07:51
@akohlmey akohlmey assigned stanmoore1 and unassigned akohlmey Apr 24, 2024
@akohlmey
Copy link
Member Author

@stanmoore1 this fixes a problem with failing macOS unit tests through github, a fix isolated from #4142 and updates the version.h file for the develop branch.

@akohlmey akohlmey added test_runs Enable to trigger run tests test_for_regression Enable to trigger regression tests and removed test_runs Enable to trigger run tests test_for_regression Enable to trigger regression tests labels Apr 28, 2024
@stanmoore1 stanmoore1 merged commit eb0640f into lammps:develop May 13, 2024
4 checks passed
@akohlmey akohlmey deleted the collected-small-changes branch May 14, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants