New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and updates to the GPU package #958

Merged
merged 7 commits into from Jun 22, 2018

Conversation

Projects
None yet
3 participants
@ndtrung81
Contributor

ndtrung81 commented Jun 20, 2018

Purpose

This PR contains bug fixes to lj/expand/coul/long its gpu version and the gpu version of coul/long/cs, born/coul/long/cs and born/coul/wolf/cs in the CORESHELL package.

Author(s)

Trung Nguyen (Northwestern)

Backward Compatibility

The changes should not break backward compatibility.

Implementation Notes

The bugs in lj/expand/coul/long and its /gpu version were due to lack of careful testing (my bad, sorry). For core-shell pair styles, the neighbor list builds on the gpu should include distance close to zero and double precision should be enforced in numerous places in the kernels.

Post Submission Checklist

Please check the fields below as they are completed

  • The feature or features in this pull request is complete
  • Suitable new documentation files and/or updates to the existing docs are included
  • One or more example input decks are included
  • The source code follows the LAMMPS formatting guidelines

@ndtrung81 ndtrung81 self-assigned this Jun 20, 2018

@akohlmey

This comment has been minimized.

Member

akohlmey commented Jun 21, 2018

@ndtrung81 please remember to assign this PR to @sjplimp when you are done with testing and it is ready to be merged. thanks, axel.

@ndtrung81 ndtrung81 assigned sjplimp and unassigned ndtrung81 Jun 21, 2018

@sjplimp sjplimp merged commit f5f73b0 into lammps:master Jun 22, 2018

5 checks passed

lammps/pull-requests/build-docs-pr head run ended
Details
lammps/pull-requests/kokkos_omp head run ended
Details
lammps/pull-requests/openmpi-pr head run ended
Details
lammps/pull-requests/serial-pr head run ended
Details
lammps/pull-requests/shlib-pr head run ended
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment