new options for log and sdata tools #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbberger
reviewed
Dec 28, 2020
| @@ -1,4 +1,4 @@ | |||
| #!/usr/local/bin/python -i | |||
| #!/usr/bin/env python -i | |||
There was a problem hiding this comment.
@sjplimp No, there is no portable way to do it that I'm aware of. IMHO this is going the wrong way since I would see pizza as an add-on package that is loaded after launching the interpreter.
src/dump.py
Outdated
| @@ -502,7 +502,7 @@ def scale_one(self,snap,x,y,z): | |||
| h4inv = (h3*h5 - h1*h4) / (h0*h1*h2) | |||
| h5inv = xy / (h0*h1) | |||
| atoms = snap.atoms | |||
| if atoms != None: | |||
| if type(atoms) != types.NoneType: | |||
There was a problem hiding this comment.
What does this enable or solve?
There was a problem hiding this comment.
don't remember. Someone told me it fixed some problem, but if you don't think so I can remove those changes.
|
@rbberger ok - I think this is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rbberger One Q on this PR. The first line of src/pizza.py now uses env. I want it to invoke "python -i" on pizza.py so that it stays in interpreter mode after loading all the tools. That works on my Mac, but not Linux (RedHat), I think b/c the syntax for env is different. So is there a portable way to do that?