Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal when test has status "broken" #203

Closed
maxistua opened this issue Apr 5, 2023 · 1 comment
Closed

Fatal when test has status "broken" #203

maxistua opened this issue Apr 5, 2023 · 1 comment

Comments

@maxistua
Copy link

maxistua commented Apr 5, 2023

Проблема:
когда тест помечен статусом skip или broken - получаем fatal error
На версии v1.18.3 работало без проблем

Вариант решения проблемы:

index 4d7150c..8e7e693 100644
--- a/runner/runner_testing.go
+++ b/runner/runner_testing.go
@@ -146,11 +146,12 @@ func (h testingHandler) HandleTest(test models.TestInterface, executeTest testEx
                result, err := executeTest(test)
                if err != nil {
                        returnErr = err
-                       t.Fatal(err)
-               }
 
-               if errors.Is(err, errTestSkipped) || errors.Is(err, errTestBroken) {
-                       t.Skip()
+                       if errors.Is(err, errTestSkipped) || errors.Is(err, errTestBroken) {
+                               t.Skip()
+                       } else {
+                               t.Fatal(err)
+                       }
                }
 
                if !result.Passed() {
~
@maxistua
Copy link
Author

maxistua commented Apr 5, 2023

Merge request: #204

@fetinin fetinin closed this as completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants