Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added table of contents. Also fixed some markdownlint issues in README. #160

Merged
merged 3 commits into from
Jun 3, 2022
Merged

Added table of contents. Also fixed some markdownlint issues in README. #160

merged 3 commits into from
Jun 3, 2022

Conversation

vitkarpenko
Copy link
Contributor

No description provided.

@vitkarpenko vitkarpenko requested a review from Cdayz June 2, 2022 15:20
README-ru.md Outdated
- [HTTP-запрос](#http-запрос)
- [HTTP-ответ](#http-ответ)
- [Переменные](#переменные)
- [Подробнее про способы присваивания](#подробнее-про-способы-присваивания)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Подробнее про" звучит как-то лишне
Можно просто "Способы присвоения"

README-ru.md Outdated
- [Проверки запросов (requestConstraints)](#проверки-запросов-requestconstraints)
- [Стратегии ответов (strategy)](#стратегии-ответов-strategy)
- [Подсчет количества вызовов](#подсчет-количества-вызовов)
- [CMD интерфейс](#cmd-интерфейс)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

он разве не CLI?

README-ru.md Outdated

- [Использование консольной утилиты](#использование-консольной-утилиты)
- [Использование gonkey как библиотеки](#использование-gonkey-как-библиотеки)
- [Пример файла с тестами](#пример-файла-с-тестами)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажется надо эту часть переименовать в "Пример тестового сценария" - потому что как мне видиться, текущая философия gonkey подразумевает что внутри одного файла мы шарим переменные между запросами и по сути строим 1 сценарий на 1 файл.

@vitkarpenko vitkarpenko added the documentation Improvements or additions to documentation label Jun 3, 2022
@vitkarpenko vitkarpenko merged commit 9b6b1be into lamoda:master Jun 3, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

🚀 PR was released in v1.17.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants