This repository has been archived by the owner on Jun 2, 2023. It is now read-only.
SCENTRE-5889 Add availability of select special strategy for queue #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TzepART
force-pushed
the
feature/SCENTRE-5889_extend_retry_sending_time
branch
2 times, most recently
from
36b491c
to
d8b2d05
Compare
Tekill
approved these changes
Jan 31, 2020
AntonTrekov
reviewed
Jan 31, 2020
|
|
||
| use Lamoda\QueueBundle\Strategy\Delay\DelayStrategyInterface; | ||
|
|
||
| class ResolverStrategyService |
There was a problem hiding this comment.
Мне что-то название не нравится. Может DelayStrategyResolver?
There was a problem hiding this comment.
Согласен, симпотичнее. Поправил
| { | ||
| $strategyKey = $this->queuesConfiguration[$queueName] ?? self::DEFAULT_STRATEGY; | ||
|
|
||
| return $this->handlers[$strategyKey]; |
There was a problem hiding this comment.
Если в массиве не будет нужного ключа, то будет TypeError. Стоит обработать, чтобы сразу была видна проблема + тестик
TzepART
force-pushed
the
feature/SCENTRE-5889_extend_retry_sending_time
branch
from
d8b2d05
to
c97aa62
Compare
TzepART
commented
Feb 3, 2020
TzepART
force-pushed
the
feature/SCENTRE-5889_extend_retry_sending_time
branch
from
c97aa62
to
fdb77cd
Compare
Tekill
approved these changes
Feb 3, 2020
dedpikhto
approved these changes
Feb 3, 2020
TzepART
force-pushed
the
feature/SCENTRE-5889_extend_retry_sending_time
branch
from
fdb77cd
to
1edeba0
Compare
AntonTrekov
approved these changes
Feb 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.