fix delay queue saving #12
Conversation
| @@ -125,7 +125,8 @@ public function getToRepublish(int $limit, ?int $offset = null): array | |||
| */ | |||
| public function createQueue(QueueInterface $queueable): QueueEntityInterface | |||
| { | |||
| return $this->entityFactory->createQueue($queueable); | |||
| $queue = $this->entityFactory->createQueue($queueable); | |||
| return $this->save($queue); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Надо дополнить тест https://github.com/lamoda/queue-bundle/blob/master/tests/unit/Service/QueueServiceTest.php
Написал
There was a problem hiding this comment.
Add a blank line before return statements, unless the return is alone inside a statement-group (like an if statement);
https://symfony.com/doc/current/contributing/code/standards.html
|
|
||
| $entityFactory = $this->getEntityFactory(); | ||
| $entityFactory | ||
| ->expects($this->once()) #at least once |
There was a problem hiding this comment.
$this->once is only once, not at least
| @@ -125,7 +125,8 @@ public function getToRepublish(int $limit, ?int $offset = null): array | |||
| */ | |||
| public function createQueue(QueueInterface $queueable): QueueEntityInterface | |||
| { | |||
| return $this->entityFactory->createQueue($queueable); | |||
| $queue = $this->entityFactory->createQueue($queueable); | |||
| return $this->save($queue); | |||
There was a problem hiding this comment.
Add a blank line before return statements, unless the return is alone inside a statement-group (like an if statement);
https://symfony.com/doc/current/contributing/code/standards.html
|
Коммиты надо схлопнуть, наверное |
No description provided.