Add compatibility for Laravel 5.5 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
mpyw
reviewed
May 12, 2020
There was a problem hiding this comment.
Thank you for submitting the PR!
Unfortunately, Resource is a soft-reserved word in the current PHP version. If we use the word in the source codes, it may cause Parse Error in the future versions. And Laravel 5.5 (LTS) will end its support term on this August.
Currently I'm not willing to merge the suggestion, sorry. Thank you anyway!
|
Ha, yes, I miss this point about Pushed a better solution. But you are free to close this PR if the following point take precedence.
|
|
@mpyw Thank you! Nice picture. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I found your library from nuwave/lighthouse#311, and I see that it does not depends on HTTP request that's excellent for an API usage such as GraphQL.
I have a project using Laravel v5.5 without time frame for a framework upgrade.
Why
Sadly I see that currently Laravel version 5.5 is not supported on this library.
So I checkout quickly the effort to make it compatible.
I do not see a direct dependency on the implementation for
...\Resourceor...\JsonResource.How
The class
Illuminate\Http\Resources\Json\Resourceextends...\JsonResourcesince Laravel version 5.5. But it is removed on version 7.0.What I see about the limitation for Laravel 5.5 is only on tests suite.
Question
Does this compatibility can going to be possible?
Next
I also try to add Laravel 7 on travis.ci tests but I got this result with issue on date format.
https://travis-ci.org/github/alquerci/lampager-laravel/jobs/686051996