Make waiting units more aggressive and allows double clicking #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 29, 2023 16:49
Give units a property "type" which is the resource name (e.g. 'tank')
berndrakell
changed the title
|
Also Closes #97 Also adds property "type" to units, which equals their script/resource names (e.g. 'Tank') |
|
Thank you! The change conceptually looks good to me - I'll make a few adjustments on top of that like changing names or extracting helper functions. Anyway, I'll merge it in upcoming days. |
|
Thanks for the feedback. Yes I'll not do that again. Tbh I didn't know new commits automatically get joined in PRs - I was never so busy :D |
Scony
added a commit
that referenced
this pull request
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #95
Also adds a property location to each unit, which holds the x and z value on the map. This property is often used in different scripts, so defining it in the unit itself is easier.