Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Dotty 0.14.0-RC1 and 0.13.0 #6235

Closed
18 of 20 tasks
biboudis opened this issue Apr 4, 2019 · 9 comments
Closed
18 of 20 tasks

Release Dotty 0.14.0-RC1 and 0.13.0 #6235

biboudis opened this issue Apr 4, 2019 · 9 comments
Assignees
Labels
itype:meta Issues about process/similar

Comments

@biboudis
Copy link
Contributor

biboudis commented Apr 4, 2019

Checklist in English

Checklist in GIT

# The following commands assume a remote tracking repository named
# `upstream` pointing to the main Dotty repo:
#
# $ git remote get-url upstream
# https://github.com/lampepfl/dotty.git

git checkout 0.13.x

# Change val baseVersion = "0.13.0-RC1" to val baseVersion = "0.13.0"

git commit -am 'Release Dotty 0.13.0'
git tag 0.13.0
git push upstream 0.13.0

git checkout master
git merge 0.13.x

# Make sure the merge doesn't break anything. In doubt, create a PR to run the CL
git push upstream master

# Milestones

git checkout -b 0.14.x

# Change val baseVersion = "0.14.0" to val baseVersion = "0.14.0-RC1"

git commit -am 'Release Dotty 0.14.0-RC1'
git tag 0.14.0-RC1
git push upstream 0.14.x
git push upstream 0.14.0-RC1

# Draft the release, get contents from:
gren changelog -G --override -D prs --tags=0.13.0-RC1..0.14.0-RC1

git checkout master

# Change val baseVersion = "0.14.0" to val baseVersion = "0.15.0"

git commit -am 'Set baseVersion to 0.15.0'
git push upstream master
@biboudis biboudis added the itype:meta Issues about process/similar label Apr 4, 2019
@allanrenucci
Copy link
Contributor

I slightly edited the git checklist

@anatoliykmetyuk
Copy link
Contributor

@biboudis can you please have a look at the drafts at the release page and see if these are fine?

Also, some questions:

SBT plugin version 0.3.2 doesn't seem to be published by the CI. This is because dotty-bootstrapped/publishSigned is used for publishing, and it doesn't seem to include the SBT plugin:

def asDottyRoot(implicit mode: Mode): Project = project.withCommonSettings.
      aggregate(`dotty-interfaces`, dottyLibrary, dottyCompiler, dottyDoc, `dotty-sbt-bridge`).
      bootstrappedAggregate(`scala-library`, `scala-compiler`, `scala-reflect`, scalap, `dotty-language-server`).

What's the procedure for publishing the SBT plugin?

Also, we do not update the following projects, right?

Another thing: the CI did not seem to include the sources in the Assets of the releases on the GitHub releases page. For all the other releases, these are present. Do we include these manually?

@biboudis
Copy link
Contributor Author

biboudis commented Apr 14, 2019

I just checked the previous releases. The src's do not appear there as well (when you edit the page). I think they get attached automatically

@smarter publishes the plugin separately and independently of this lifecycle I think

com-lihaoyi/mill#569 seems merged but a new version of mill is not released

LGTM @anatoliykmetyuk

Let's press the merge on the blogpost tomorrow morning after the rest from the checklist are done

Good job

@smarter
Copy link
Member

smarter commented Apr 14, 2019

What's the procedure for publishing the SBT plugin?

drone deploy lampepfl/dotty $id sbt_release

where $id is a job id from the CI, e.g. 12070 for http://dotty-ci.epfl.ch/lampepfl/dotty/12070.

But there's been no changes to sbt-dotty since the last release so there's nothing that needs to be published right now.

@anatoliykmetyuk
Copy link
Contributor

Unfortunately, I can't publish the post to Scala Contributors since "the new users can only include 10 links in their post". @biboudis can you please do it for me? The source is here.

@biboudis
Copy link
Contributor Author

Done

@biboudis
Copy link
Contributor Author

homebrew-brew and packtest are merged right @anatoliykmetyuk ?

@anatoliykmetyuk
Copy link
Contributor

Yes, they are merged

@biboudis
Copy link
Contributor Author

I updated the checklist above 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
itype:meta Issues about process/similar
Projects
None yet
Development

No branches or pull requests

4 participants