Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up settings #10655

Merged
merged 7 commits into from
Dec 10, 2020
Merged

Clean up settings #10655

merged 7 commits into from
Dec 10, 2020

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Dec 4, 2020

A first batch.

@sjrd sjrd requested a review from smarter December 4, 2020 15:34
@sjrd sjrd mentioned this pull request Dec 4, 2020
Closed
@smarter smarter added the release-notes Should be mentioned in the release notes label Dec 4, 2020
smarter
smarter approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@sjrd
Copy link
Member Author

sjrd commented Dec 4, 2020

That was fast ^^

@sjrd
Copy link
Member Author

sjrd commented Dec 4, 2020

@abgruszecki The failure in "CI for Scala3doc / community-docs" seems spurious. Is it? Or did I actually break something?

@abgruszecki
Copy link
Contributor

@sjrd it's the compilation that failed, of all things. I'm not sure if the failure is spurious. Did we break CLI API compat?

@sjrd sjrd force-pushed the cleanup-settings branch 3 times, most recently from 6f5b9b7 to 7570c6c Compare December 9, 2020 12:51
@sjrd
Remove unused setting -Xrepl-line-width.
a803f63
@sjrd
Remove untested setting -Yoverride-vars and its effects.
e855eaa 
There is no test covering that setting, and Scala 2.13 does not
have it either.
@sjrd
Remove the setting -Ytrace-context-creation.
a6f6913 
It doesn't do anything on its own, because the code that takes it
into account is commented out. Since we have to uncomment it to
enable it, there is no point in also having a setting.
@sjrd
Remove non implemented setting -Yshow-raw-tree.
8f37853 
As well as the parameter in the `Settings` of staging, which were
affecting the value of that setting (to no effect).
@sjrd
Remove the non implemented setting -Yparallel-pickler.
c0220ba
@sjrd
Fix the doc string of two settings.
5ef50a0
@sjrd
Reclassify -Ysemanticdb as -Xsemanticdb, as it is officially supported.
4bc743e 
We keep -Ysemanticdb as an alias (an "abbreviation") so that we do
not break all the existing tools that enable that setting.
@sjrd
Copy link
Member Author

sjrd commented Dec 10, 2020

I had to take out the rename of -noindent because I couldn't make the community docs build pass with it, even when keeping the old spelling as an abbreviation. I have no idea what is happening there. I will resubmit as a separate PR for someone else to figure out.

@sjrd sjrd merged commit ff3637f into scala:master Dec 10, 2020
@sjrd sjrd deleted the cleanup-settings branch December 10, 2020 08:15
@adpi2 adpi2 mentioned this pull request Dec 25, 2020
Merged
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees

@smarter smarter

Labels
release-notes Should be mentioned in the release notes
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sjrd @abgruszecki @smarter @Kordyjan