Rework reflect show API #10661
Rework reflect show API #10661
Conversation
nicolasstucki
force-pushed
the
rework-reflect-show-api
branch
3 times, most recently
from
a2cab66
to
c40a99e
Compare
nicolasstucki
force-pushed
the
rework-reflect-show-api
branch
3 times, most recently
from
643642f
to
da9861a
Compare
| def ConstantAnsiCode: Printer[Constant] | ||
|
|
||
| /** Prints a pattern like representation of the `Constant`. */ | ||
| def ConstantCases: Printer[Constant] |
There was a problem hiding this comment.
Are Constant printers necessary? I assume they are part of the tree printers?
There was a problem hiding this comment.
Constant is not a Tree. But indeed, the TreeCases printer does print Constant using the equivalent of ConstantCases.
It is necessary if you have a Constant and want to show it without having to put it back in a Literal to then call show.
There was a problem hiding this comment.
If they are not very useful, then I'd suggest removing them to make it easier for programmers to choose printers they care about most of the time.
There was a problem hiding this comment.
Simplified the Constant.show to not take a printer
nicolasstucki
force-pushed
the
rework-reflect-show-api
branch
from
da9861a
to
848163f
Compare
* Add `reflect.Printer[T]` type class * Define `show` method in reflect based on `Printer` * Provide a single default `show` for `Expr` and `Type` (use `reflect` to access other printers) * Only define printers that make sence for the given types. * Remove `Symbol.show`. Use directly `Symbol.fullName` instead.
nicolasstucki
force-pushed
the
rework-reflect-show-api
branch
from
848163f
to
3df32d4
Compare
| /** Type class used in `show` methods to provide customizable `String` representations */ | ||
| trait Printer[T]: | ||
| /** Show the arguments as a `String` */ | ||
| def show(x: T): String |
There was a problem hiding this comment.
With Printer being a member of the Reflection trait, it seems very tricky for users to write their own custom printer that works with any Reflection context. Is there an example of how to do that? If it's not possible maybe we can come up with a better API here.
There was a problem hiding this comment.
There are examples of how to use the Tree map that is quite similar. I will add an example for printer.
|
So instead of: term.showExtractorsWe do: Printer.TreeStructure.show(term)That's quite a bit more that user a needs to remember. |
|
The idea is to use |
|
Thanks for the info. The thing about I can think of some alternatives would do codebase-wide but this call was so, so nice to quickly use! |
|
I remember there was even a compiler error at some point where if you didn't match a tree correctly it would tell you to use |
No description provided.