remove dottydoc #11349
remove dottydoc #11349
Conversation
Replaced by which command in the distro ?! Note: |
| @@ -21,6 +20,7 @@ val `tasty-core` = Build.`tasty-core` | |||
| val `tasty-core-bootstrapped` = Build.`tasty-core-bootstrapped` | |||
| val `tasty-core-scala2` = Build.`tasty-core-scala2` | |||
| val scaladoc = Build.scaladoc | |||
| val `scaladoc-nonBootstrapped` = Build.`scaladoc-nonBootstrapped` | |||
There was a problem hiding this comment.
Any particular reason to not make the nonbootstrapped the default one like for the other projects? Also if this stays in, this should be renamed to nonbootstrapped all lowercase to match scala3-tasty-inspector-nonbootstrapped above
There was a problem hiding this comment.
The *-bootstrapped projects are ones that we want to used in most cases so having a longer name there is a bit misleading. Also both scaladoc and tastyinspector are currently used in bootstrapped context so I didn't wanted to change all this places to scaladoc-bootstrapped
| @@ -1230,6 +1159,10 @@ object Build { | |||
| val generateScalaDocumentation = inputKey[Unit]("Generate documentation for dotty lib") | |||
| val generateTestcasesDocumentation = taskKey[Unit]("Generate documentation for testcases, usefull for debugging tests") | |||
| lazy val `scaladoc` = project.in(file("scaladoc")).asScaladoc | |||
| lazy val `scaladoc-nonBootstrapped` = project.in(file("scaladoc")).scaladocBasic(NonBootstrapped).settings( | |||
| sources.in(Test) := Nil | |||
There was a problem hiding this comment.
Can the tests not be run with the nonbootstrapped project for some reason? If so, that's worth explaining in a comment.
There was a problem hiding this comment.
I will add a comment.
romanowski
force-pushed
the
scaladoc/remote-dottydoc
branch
from
08720b3
to
7945596
Compare
Yes, I will include that as well. TBH I should mark this PR as draft in first place, sorry. |
romanowski
force-pushed
the
scaladoc/remote-dottydoc
branch
from
f28c9a2
to
0d8b672
Compare
romanowski
force-pushed
the
scaladoc/remote-dottydoc
branch
2 times, most recently
from
bc6b18b
to
51643d7
Compare
project/scripts/bootstrapCmdTests
Outdated
| "$SBT" "scala3-bench/jmh:run 1 1 tests/pos/alias.scala" | ||
| # The above is here as it relies on the bootstrapped library. | ||
| "$SBT" "scala3-bench-bootstrapped/jmh:run 1 1 tests/pos/alias.scala" | ||
| "$SBT" "scala3-bench-bootstrapped/jmh:run 1 1 -with-compiler compiler/src/dotty/tools/dotc/core/Types.scala" | ||
| # "$SBT" "scala3-bench/jmh:run 1 1 tests/pos/alias.scala" | ||
| # # The above is here as it relies on the bootstrapped library. | ||
| # "$SBT" "scala3-bench-bootstrapped/jmh:run 1 1 tests/pos/alias.scala" | ||
| # "$SBT" "scala3-bench-bootstrapped/jmh:run 1 1 -with-compiler compiler/src/dotty/tools/dotc/core/Types.scala" | ||
|
|
||
| echo "testing scala.quoted.Expr.run from sbt scala" | ||
| "$SBT" ";scala3-compiler-bootstrapped/scalac -with-compiler tests/run-staging/quote-run.scala; scala3-compiler-bootstrapped/scala -with-compiler Test" > "$tmp" | ||
| grep -qe "val a: scala.Int = 3" "$tmp" | ||
| # echo "testing scala.quoted.Expr.run from sbt scala" | ||
| # "$SBT" ";scala3-compiler-bootstrapped/scalac -with-compiler tests/run-staging/quote-run.scala; scala3-compiler-bootstrapped/scala -with-compiler Test" > "$tmp" | ||
| # grep -qe "val a: scala.Int = 3" "$tmp" | ||
|
|
||
|
|
||
| # setup for `scalac`/`scala` script tests | ||
| "$SBT" dist/pack | ||
| # "$SBT" dist/pack | ||
|
|
There was a problem hiding this comment.
Why did these tests get commented out?
There was a problem hiding this comment.
Leftover from local debugging (benchmarks, even such small takes a while to run)
romanowski
force-pushed
the
scaladoc/remote-dottydoc
branch
from
51643d7
to
888ac94
Compare
romanowski
force-pushed
the
scaladoc/remote-dottydoc
branch
from
888ac94
to
5de44e0
Compare
No description provided.