-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to cyclic checking, avoidance, named parameters #1186
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
0855b07
Fixes to checkNonCyclic
odersky b490347
Simplify and fix avoid logic
odersky a44082f
Add test for #1181 to pending
odersky e7e81d0
Fix type-shifting problem in vcInlineMethods
odersky 04be034
Fix error message output.
odersky bbbb662
Fix test case.
odersky 0474de6
Fix bug in printing New nodes
odersky d0f9848
Add methods for expressing named type params
odersky c03c8ca
Take named type parameters into account when instantiating variables.
odersky 506c106
Don't lambda expand and/or types over named type parameters
odersky 6d2a3d3
Test cases
odersky de870e2
Adapt type assignment for AppliedTypeTrees to new named params
odersky 78d2c9a
Simplify widenToParents
odersky 2474c1b
Fix a case in deskolemize.
odersky f8aa4b3
Fix documentation of liftIfHK
odersky 78545bb
Add ApproximatingTypeMap class
odersky d897678
Base deskolemize on ApproximatingTypeMap
odersky f675ad9
Domain checking for named type parameters
odersky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we create a
NameFilter
instance that filters named type params directly instead?