Streamline given syntax #12107
Merged
Streamline given syntax #12107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A simple fix for the problem that
```scala
given SomeClass with {}
```
is ugly and
```scala
given SomeClass = SomeClass()
```
is repetitive: We now also allow
```scala
given SomeClass()
```
It can't be confused for an abstract given clause because of the `()`.
|
As a note, this fix also works for the following case (already in the test): class Ctx(x: Int)
- given Ctx(5) with {}
+ given Ctx(5) |
tgodzik
added a commit
to tgodzik/scalameta
that referenced
this pull request
Jul 13, 2021
tgodzik
added a commit
to tgodzik/scalameta
that referenced
this pull request
Jul 13, 2021
tgodzik
added a commit
to tgodzik/scalameta
that referenced
this pull request
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix for the problem that
is ugly and
is repetitive: We now also allow
It can't be confused for an abstract given clause because of the
().